Re: [Qemu-devel] [RFC 2/5] hw/arm: add very initial support for Canon DIGIC SoC

[Antony Pavlov]

On Thu, 29 Aug 2013 16:29:30 +0200
Condello <address@hidden> wrote:

> On Thu, Aug 29, 2013 at 11:33 AM, Antony Pavlov <address@hidden> wrote:
> > diff --git a/default-configs/arm-softmmu.mak 
> > b/default-configs/arm-softmmu.mak
> > index ac0815d..0d1d783 100644
> > --- a/default-configs/arm-softmmu.mak
> > +++ b/default-configs/arm-softmmu.mak
> > @@ -63,6 +63,7 @@ CONFIG_FRAMEBUFFER=y
> >  CONFIG_XILINX_SPIPS=y
> >
> >  CONFIG_A9SCU=y
> > +CONFIG_DIGIC=y
> 
> IMHO CONFIG_DIGIC should really be CONFIG_DIGIC_4. We don't know how
> the DIGIC package will change in the future but it doesn't hurt since
> everything else references digic4 already.

There are two reasons to use CONFIG_DIGIC, but not CONFIG_DIGIC4:

1. CONFIG_DIGIC is used not only for SoC support enabling but for IP-block 
(UART and TIMER) enabling too. But this blocks are used not only in DIGIC4, so 
if you use
CONFIG_DIGIC4 for SoC enabling you need use something like CONFIG_DIGIC_UART and
CONFIG_DIGIC_TIMER for IP-block enabling. But if you enable your CONFIG_DIGIC4
but CONFIG_DIGIC_UART is disabled then qemu fails to start digic board
(I unintentionally checked this fact yesterday :).
Does we really need this overcomplication?

Just now it is not evident how to make the partition of the code.

2. AFAIR the digic chips are different but the core functionality is the same.
I have red in CHDK forum about a programm for DIGIC3 that run well on DIGIC4.

-- 
Best regards,
  Antony Pavlov