Re: [Qemu-devel] [PULLv2 0/7] s390x/kvm kdump and reset related changes

[Alexander Graf]

On 30.08.2013, at 14:41, Christian Borntraeger wrote:

> Alex, 
> 
> here is the adopted series.
> - Patch 1 is new, to make patch2 look better
> - Patch 2 was adopted to move everything into misc helper
>  please note: I did not wire up the tcg diag handler for known reasons
>               This should be trivial to implement
> - Patch 5 was also slightly adopted to make the full reset identical to
>  the previous state (The old patch changed the order of some reset steps)
> - Patch 6 was adopted to also go into misc_helper
> - Patch 3,4,7 are unchanged
> All patches compile- and checkpatch tested. kdump functionality, reboot,
> signal quiesce, cpu online/offline tested on s390x/kvm. Basic run of s390x 
> emulation on i386 also tested.
> 
> Please ACK the series.

Acked-by: Alexander Graf <address@hidden>


Alex

> Anthony, can you pull afterwards?
> 
> The following changes since commit b5d54bd42158b90b239bb6ce9c13072eb3a53fd2:
> 
>  Merge remote-tracking branch 'qemu-kvm/uq/master' into stable-1.5 
> (2013-08-29 17:21:51 -0500)
> 
> are available in the git repository at:
> 
> 
>  git://github.com/borntraeger/qemu.git tags/kdump
> 
> for you to fetch changes up to 7f7f975295bc19829b3bd26cadc7f1c9eadb7c6b:
> 
>  s390: wire up nmi command to raise a RESTART interrupt on S390 (2013-08-30 
> 14:16:48 +0200)
> 
> ----------------------------------------------------------------
> This is a set of patches dealing with kdump support for s390x/kvm.
> kdump on s390x uses subcode 1 of diagnose 0x308 to put the hardware
> in a defined state. This is different from a full reset, since it
> does not touch all CPU registers.
> These patches define the cpu resets, the subsystem reset a load
> function and also wires up the "nmi" command to issue a RESTART
> interrupt as defined in the z/Architecture principles of operation.
> 
> This allows recent guest kernels with properly setup userspace
> to trigger kdump:
> - via guest crash
> - via nmi from the host
> 
> ----------------------------------------------------------------
> Christian Borntraeger (5):
>      s390x/kvm: Fix switch/case indentation for handle_diag
>      s390: provide I/O subsystem reset
>      s390: provide a cpu load normal function
>      s390/cpu: split CPU reset into architectured functions
>      s390: Implement load normal reset
> 
> Eugene (jno) Dvurechenski (2):
>      s390/kvm: basic implementation of diagnose 308 subcode 6
>      s390: wire up nmi command to raise a RESTART interrupt on S390
> 
> cpus.c                     | 14 ++++++++++
> hmp-commands.hx            |  4 +--
> hw/s390x/s390-virtio-ccw.c | 15 ++++++++++
> qmp-commands.hx            |  2 +-
> target-s390x/cpu-qom.h     |  6 ++++
> target-s390x/cpu.c         | 52 ++++++++++++++++++++++++++++++++--
> target-s390x/cpu.h         | 20 +++++++++++++
> target-s390x/kvm.c         | 40 +++++++++++++++++---------
> target-s390x/misc_helper.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++
> 9 files changed, 204 insertions(+), 19 deletions(-)
>