[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V7 5/5] block: Add iops_size to do the iops acco
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V7 5/5] block: Add iops_size to do the iops accounting for a given io size. |
Date: |
Fri, 30 Aug 2013 08:39:45 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 08/28/2013 09:07 AM, Benoît Canet wrote:
> This feature can be used in case where users are avoiding the iops limit by
> doing jumbo I/Os hammering the storage backend.
>
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> block/qapi.c | 3 +++
> blockdev.c | 21 ++++++++++++++++++---
> hmp.c | 8 ++++++--
> qapi-schema.json | 10 ++++++++--
> qemu-options.hx | 2 +-
> qmp-commands.hx | 8 ++++++--
> 6 files changed, 42 insertions(+), 10 deletions(-)
>
> @@ -1429,7 +1430,8 @@ Example:
> "bps_wr_max": "0",
> "iops_max": "0",
> "iops_rd_max": "0",
> - "iops_wr_max": "0" } }
> + "iops_wr_max": "0",
> + "iops_size": "0" } }
Oh phooey, I failed to notice this on 4/5 - "0" is not a JSON int. This
should be "bps_wr_max":0, ..., "iops_size": 0 } }
> <- { "return": {} }
>
> EQMP
> @@ -1776,6 +1778,7 @@ Each json-object contain the following:
> - "iops_max": total I/O operations max (json-int)
> - "iops_rd_max": read I/O operations max (json-int)
> - "iops_wr_max": write I/O operations max (json-int)
> + - "iops_size": I/O size when limiting by iops (json-int)
> - "image": the detail of the image, it is a json-object containing
> the following:
> - "filename": image file name (json-string)
> @@ -1851,6 +1854,7 @@ Example:
> "iops_max": "0",
> "iops_rd_max": "0",
> "iops_wr_max": "0",
> + "iops_size": "0",
Here, too. All of the integers should be represented literally, not
inside quotes.
But since the problem is pre-existing before your series, and you are
just the victim of copy-and-paste, I'm okay saving the cleanup to a
separate patch, in which case:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V7 0/5] Continuous Leaky Bucket Throttling, Benoît Canet, 2013/08/28
- [Qemu-devel] [PATCH V7 1/5] throttle: Add a new t hrottling API implementing continuous leaky bucket., Benoît Canet, 2013/08/28
- [Qemu-devel] [PATCH V7 2/5] throttle: Add units t ests, Benoît Canet, 2013/08/28
- [Qemu-devel] [PATCH V7 3/5] block: Enable the new throttling code in the block layer., Benoît Canet, 2013/08/28
- [Qemu-devel] [PATCH V7 4/5] block: Add support fo r throttling burst max in QMP and the command line., Benoît Canet, 2013/08/28
- [Qemu-devel] [PATCH V7 5/5] block: Add iops_siz e to do the iops accounting for a given io size., Benoît Canet, 2013/08/28
- Re: [Qemu-devel] [PATCH V7 5/5] block: Add iops_size to do the iops accounting for a given io size.,
Eric Blake <=
- Re: [Qemu-devel] [PATCH V7 0/5] Continuous Leaky Bucket Throttling, Stefan Hajnoczi, 2013/08/29
- Re: [Qemu-devel] [PATCH V7 0/5] Continuous Leaky Bucket Throttling, Benoît Canet, 2013/08/29