|
From: | Michael Tokarev |
Subject: | Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp/arp_table.c: Avoid shifting into sign bit of signed integers |
Date: | Sun, 01 Sep 2013 19:09:47 +0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130827 Icedove/17.0.8 |
23.08.2013 20:36, Peter Maydell wrote:
"0xf << 28" shifts right into the sign bit, since 0xf is a signed integer. Use the 'U' suffix to force an unsigned shift to avoid this undefined behaviour and a clang sanitizer warning.
Thanks, applied to the trivial-patches queue. /mjt
[Prev in Thread] | Current Thread | [Next in Thread] |