[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] forward cpuid leaves when using -cpu host
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH] forward cpuid leaves when using -cpu host |
Date: |
Mon, 2 Sep 2013 09:58:18 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Sep 02, 2013 at 02:45:48PM +0200, Benoît Canet wrote:
>
> Ping,
>
> I am aware that this patch must be a QObject/CPUState monstruosity but I don't
> see how I could store the fact that the cpu derive from a "host" type cpu.
> The alternative would be to remember a variable number of leaves and serving
> them to the guest as needed but I don't find that much cleaner.
The idea makes sense for -cpu host, and it is not intrusive for all
other CPU models. I just didn't take the time to look at the code to
send my "reviewed-by:" line yet. I plan to take a look today or
tomorrow.
>
> Best regards
>
> Benoît
>
> > Le Tuesday 27 Aug 2013 à 22:38:25 (+0200), Benoît Canet a écrit :
> > This patch uses directly cpuid_host to forward the informations instead of
> > storing a variable number of leaves in the cpu states.
> >
> > Benoît Canet (1):
> > i386: forward CPUID cache leaves when -cpu host is used
> >
> > target-i386/cpu.c | 19 +++++++++++++++++++
> > target-i386/cpu.h | 1 +
> > 2 files changed, 20 insertions(+)
> >
> > --
> > 1.7.10.4
> >
--
Eduardo