[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-iotests: Fixed test case 026
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-iotests: Fixed test case 026 |
Date: |
Mon, 2 Sep 2013 15:07:39 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 02.09.2013 um 14:58 hat Stefan Hajnoczi geschrieben:
> On Mon, Sep 02, 2013 at 02:42:00PM +0200, Kevin Wolf wrote:
> > diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> > index 74628ae..42d6955 100755
> > --- a/tests/qemu-iotests/check
> > +++ b/tests/qemu-iotests/check
> > @@ -239,12 +239,18 @@ do
> > echo -n " [failed, exit status $sts]"
> > err=true
> > fi
> > - if [ ! -f $seq.out ]
> > +
> > + reference=$seq.out
>
> Please keep the same indentation style as the rest of the file (seems to
> use 8-space tabs plus spaces for 4-space indentation).
I could live with just tabs, but this kind of mix is a totally broken
style. :-/
I'd rather send a patch to convert the whole qemu-iotests scripts to
spaces first. Would you agree with that?
> > + if (echo $QEMU_IO_OPTIONS | grep -s -- '--nocache' > /dev/null);
> > then
>
> man grep says:
> "Portable shell scripts should avoid both -q and -s and should redirect
> standard and error output to /dev/null instead."
>
> Since you're already redirecting stdout to /dev/null we might as well
> redirect stderr too and drop the -s option.
Okay, will do in v2, though I generally don't care about portability of
qemu-iotests.
Kevin