[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 0/6] block/qcow2: Image file option amendment
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5 0/6] block/qcow2: Image file option amendment |
Date: |
Tue, 3 Sep 2013 10:42:00 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 03.09.2013 um 10:09 hat Max Reitz geschrieben:
>
> This series adds support to qemu-img, block and qcow2 for amending image
> options on existing image files.
>
> Depends on:
> - option: Add assigned flag to QEMUOptionParameter
> - qcow2-refcount: Snapshot update for zero clusters (series, v3)
> - Add metadata overlap checks (series, v5)
>
> v5:
> - added a new function for emptying a cache (patch 2)
> - fixed rounding for the bitmap size in qcow2_expand_zero_clusters
> - now empties the cache in qcow2_expand_zero_clusters instead of simply
> flushing it
> - factored out assignment check in qcow2_amend_options
> - fixed resizing by moving it to the end of qcow2_amend_options
> - fixed expected test result for resizing in addition to a version
> upgrade
There's still room for improvements on top, in particular the additional
test cases I suggested in the v4 thread and the real qcow2_truncate()
fix that is just worked around here by moving its call (it needs to
update bs->total_sectors), but this looks good enough to be merged now.
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH v5 0/6] block/qcow2: Image file option amendment, Max Reitz, 2013/09/03
- [Qemu-devel] [PATCH v5 1/6] block: Image file option amendment, Max Reitz, 2013/09/03
- [Qemu-devel] [PATCH v5 2/6] qcow2-cache: Empty cache, Max Reitz, 2013/09/03
- [Qemu-devel] [PATCH v5 3/6] qcow2-cluster: Expand zero clusters, Max Reitz, 2013/09/03
- [Qemu-devel] [PATCH v5 6/6] qemu-iotest: qcow2 image option amendment, Max Reitz, 2013/09/03
- [Qemu-devel] [PATCH v5 5/6] qcow2: Implement bdrv_amend_options, Max Reitz, 2013/09/03
- [Qemu-devel] [PATCH v5 4/6] qcow2: Save refcount order in BDRVQcowState, Max Reitz, 2013/09/03
- Re: [Qemu-devel] [PATCH v5 0/6] block/qcow2: Image file option amendment,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH v5 0/6] block/qcow2: Image file option amendment, Kevin Wolf, 2013/09/09