[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv7] add qemu-img convert -n option (skip target v
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCHv7] add qemu-img convert -n option (skip target volume creation) |
Date: |
Tue, 3 Sep 2013 11:32:48 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Sep 02, 2013 at 07:07:24PM +0100, Alex Bligh wrote:
> From: Alexandre Derumier <address@hidden>
>
> Add a -n option to skip volume creation on qemu-img convert.
> This is useful for targets such as rbd / ceph, where the
> target volume may already exist; we cannot always rely on
> qemu-img convert to create the image, as dependent on the
> output format, there may be parameters which are not possible
> to specify through the qemu-img convert command line.
>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Alexandre Derumier <address@hidden>
> Signed-off-by: Alex Bligh <address@hidden>
> ---
>
> Changes since v6:
> * Check for outut file too short using bdrv_getlength (Stefan H)
> * Remove spurious comment re compression from test (Stefan H)
> * Remove unused variables from test (Stefan H)
>
> Changes since v5:
> * Change order of case statement for -n to be after -q
> * Add my own copyright string (per Eric Blake)
>
> qemu-img-cmds.hx | 4 +-
> qemu-img.c | 53 +++++++++++++++++-------
> qemu-img.texi | 15 ++++++-
> tests/qemu-iotests/060 | 97
> ++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/060.out | 10 +++++
> tests/qemu-iotests/group | 1 +
> 6 files changed, 162 insertions(+), 18 deletions(-)
Due to the collision with Max's 060 I changed your test case number to
063.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan