qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-module


From: Peter Maydell
Subject: Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules
Date: Wed, 11 Sep 2013 11:58:28 +0100

On 11 September 2013 11:37, Gerd Hoffmann <address@hidden> wrote:
>> What is the num_pages field supposed to mean, given that
>> "page size" isn't a well defined platform independent value
>> (for hardware or for QEMU)?
>
> It's 4k on x86 and not really defined on !x86 (with the !x86 installed
> base being pretty close to zero).
>
> I think we should just define it to be 4k everywhere.

Yeah, if you're just using it as a "we didn't want a 64 bit
field so we could make this a simple byte count" then
saying "it's in units of 4K" is the simplest fix.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]