[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 01/29] tcg-aarch64: Set ext based on TCG_OPF_
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH v3 01/29] tcg-aarch64: Set ext based on TCG_OPF_64BIT |
Date: |
Thu, 12 Sep 2013 11:01:14 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
On 12.09.2013 10:58, Peter Maydell wrote:
> On 12 September 2013 09:25, Claudio Fontana <address@hidden> wrote:
>> On 02.09.2013 19:54, Richard Henderson wrote:
>>>
>>> - case INDEX_op_bswap64_i64:
>>> - ext = 1; /* fall through */
>>> case INDEX_op_bswap32_i64:
>>> + /* Despite the _i64, this is a 32-bit bswap. */
>>> + ext = 0;
>>> + /* FALLTHRU */
>>> + case INDEX_op_bswap64_i64:
>>
>> we waste too much y space here, which gives context and is a scarse resource.
>> What about
>>
>> case INDEX_op_bswap32_i64: /* Despite the _i64, this is a 32-bit bswap. */
>> ext = false; /* FALLTHRU */
>
> Consensus in the rest of the code is for /* fall through */
> rather than /* FALLTHRU */ -- there's only 28 of the
> latter compared to 169 of the former.
>
I like /* fall through */ better as well.
[Qemu-devel] [PATCH v3 04/29] tcg-aarch64: Hoist common argument loads in tcg_out_op, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 05/29] tcg-aarch64: Change enum aarch64_arith_opc to AArch64Insn, Richard Henderson, 2013/09/02
[Qemu-devel] [PATCH v3 02/29] tcg-aarch64: Change all ext variables to bool, Richard Henderson, 2013/09/02