[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 5/9] module: implement module loading functio
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v8 5/9] module: implement module loading function |
Date: |
Fri, 13 Sep 2013 18:05:35 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, 09/13 10:56, Alex Bligh wrote:
>
> On 13 Sep 2013, at 09:38, Fam Zheng wrote:
>
> > Added three types of modules:
> >
> > typedef enum {
> > MODULE_LOAD_BLOCK = 0,
> > MODULE_LOAD_UI,
> > MODULE_LOAD_NET,
> > MODULE_LOAD_MAX,
> > } module_load_type;
> >
> > and their loading function:
>
> What is the advantage of this enum and having
> different types of module at all? If they are
> all built together, why can't they all live
> together in the same directory?
>
> Seems like an overcomplication.
>
They anyway need to be grouped: block drivers are almost always loaded, but not
ui, or net (although they're not modulized in this series), and they shouldn't
be loaded, from example by qemu-img, because of missing necessary functions.
For this reason, I don't think subdirecotry is an overcomplication over file
name prefix/postfix, or arrays of file name lists.
Fam
- [Qemu-devel] [PATCH v8 0/9] Shared Library Module Support, Fam Zheng, 2013/09/13
- [Qemu-devel] [PATCH v8 1/9] ui/Makefile.objs: delete unnecessary cocoa.o dependency, Fam Zheng, 2013/09/13
- [Qemu-devel] [PATCH v8 2/9] make.rule: fix $(obj) to a real relative path, Fam Zheng, 2013/09/13
- [Qemu-devel] [PATCH v8 3/9] rule.mak: allow per object cflags and libs, Fam Zheng, 2013/09/13
- [Qemu-devel] [PATCH v8 4/9] build-sys: introduce common-obj-m and block-obj-m for DSO, Fam Zheng, 2013/09/13
- [Qemu-devel] [PATCH v8 5/9] module: implement module loading function, Fam Zheng, 2013/09/13
- [Qemu-devel] [PATCH v8 6/9] module: add configurable module whitelist, Fam Zheng, 2013/09/13
- [Qemu-devel] [PATCH v8 7/9] Makefile: install modules with "make install", Fam Zheng, 2013/09/13
- [Qemu-devel] [PATCH v8 8/9] .gitignore: ignore module related files (dll, so, mo), Fam Zheng, 2013/09/13
- [Qemu-devel] [PATCH v8 9/9] block: convert block drivers linked with libs to modules, Fam Zheng, 2013/09/13