Re: [Qemu-devel] [PATCH 21/47] hw/char/Kconfig: Add Kconfig file

[Paolo Bonzini]

Il 13/09/2013 16:00, Andreas Färber ha scritto:
>> > I have no objection to hw/ipack, but I have a question.  Would you
>> > follow the SCSI/USB model (with devices under hw/ipack, also followed
>> > for IndustryPack in the Linux kernel) or the virtio model (where the
>> > device remains under hw/char)?  Generally we've tried to follow Linux
>> > for hw/ structure unless maintainers preferred otherwise, so it would
>> > prefer the former.
> My quest is a) consistency and b) easily finding QOM base device classes
> for refactorings. PCI and USB were done before your big hw/
> reorganization, and the biggest part of devices appears to follow the
> categorization by function (which is why I saw the overlap with Marcel's
> category markup). ipoctal232 looks correct in hw/char/ to me, so that it
> can benefit from any general char device refactorings.

Yeah, I agree.  But I'm not sure of the benefit of an hw/ipack directory
if (a) there is only one class providing the bus and (b) all the classes
using the bus (well, there is just one of them) are in the same directory.

If any of the two conditions were not true anymore, I'd ask to
contextually create hw/ipack.  But for now, keeping both ipack files in
hw/char is the most "economic" thing to do.

Paolo