qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/6] QMP: qmp-events.txt: minor fixes


From: Luiz Capitulino
Subject: Re: [Qemu-devel] [PATCH 6/6] QMP: qmp-events.txt: minor fixes
Date: Fri, 13 Sep 2013 14:01:25 -0400

On Wed, 11 Sep 2013 17:30:48 -0600
Eric Blake <address@hidden> wrote:

> On 09/11/2013 02:52 PM, Luiz Capitulino wrote:
> > Signed-off-by: Luiz Capitulino <address@hidden>
> > ---
> >  docs/qmp/qmp-events.txt | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
> > index 39b6016..1e91f45 100644
> > --- a/docs/qmp/qmp-events.txt
> > +++ b/docs/qmp/qmp-events.txt
> > @@ -1,4 +1,4 @@
> > -                   QEMU Monitor Protocol Events
> > +                   QEMU Machine Protocol Events
> >                     ============================
> >  
> >  BALLOON_CHANGE
> > @@ -173,7 +173,7 @@ Data:
> >    "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> >  
> >  NIC_RX_FILTER_CHANGED
> > ------------------
> > +---------------------
> >  
> >  The event is emitted once until the query command is executed,
> >  the first event will always be emitted.
> > 
> 
> Reviewed-by: Eric Blake <address@hidden>
> 
> But incomplete.  DEVICE_DELETED has a too-long delimiter, GUEST_PANICKED
> is out of order,

Fixed those.

> and it's probably worth splitting SPICE_CONNECTED and
> SPICE_DISCONNECTED into separate sections (matching VNC_CONNECTED and
> VNC_DISCONNECTED).

This probably better done in a different patch. Will left for another day.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]