[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/15] iov: avoid "orig_len may be used unitialized"
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 11/15] iov: avoid "orig_len may be used unitialized" warning |
Date: |
Sat, 14 Sep 2013 23:47:37 +0400 |
Signed-off-by: Wenchao Xia <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
util/iov.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/util/iov.c b/util/iov.c
index f705586..bb46c04 100644
--- a/util/iov.c
+++ b/util/iov.c
@@ -181,13 +181,11 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov,
unsigned iov_cnt,
assert(iov[niov].iov_len > tail);
orig_len = iov[niov].iov_len;
iov[niov++].iov_len = tail;
- }
-
- ret = do_send_recv(sockfd, iov, niov, do_send);
-
- /* Undo the changes above before checking for errors */
- if (tail) {
+ ret = do_send_recv(sockfd, iov, niov, do_send);
+ /* Undo the changes above before checking for errors */
iov[niov-1].iov_len = orig_len;
+ } else {
+ ret = do_send_recv(sockfd, iov, niov, do_send);
}
if (offset) {
iov[0].iov_base -= offset;
--
1.7.10.4
- [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 07/15] *-user: Improve documentation for lock_user function, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 01/15] configure: Undefine _FORTIFY_SOURCE prior using it, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 03/15] docs: Fix IO port number for CPU present bitmap., Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 05/15] translate-all: Fix formatting of dump output, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 02/15] q35: Fix typo in constant DEFUALT -> DEFAULT., Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 10/15] vscclient: remove unnecessary use of uninitialized variable, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 11/15] iov: avoid "orig_len may be used unitialized" warning,
Michael Tokarev <=
- [Qemu-devel] [PULL 13/15] Makefile: Remove some more files when cleaning, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 09/15] trace-events: Clean up with scripts/cleanup-trace-events.pl again, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 06/15] MAINTAINERS: Add missing entry to filelist for TCI target, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 14/15] tcg-sparc: Fix parenthesis warning, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 12/15] target-i386: Fix segment cache dump, Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 08/15] tci: Fix qemu-alpha on 32 bit hosts (wrong assertions), Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 04/15] *-user: Fix typo in comment (ulocking -> unlocking), Michael Tokarev, 2013/09/14
- [Qemu-devel] [PULL 15/15] configure: Enable extra compiler warnings, Michael Tokarev, 2013/09/14
- Re: [Qemu-devel] [PULL 00/15] trivial patches for 2013-09-14, Anthony Liguori, 2013/09/17