Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command

[Kevin Wolf]

Am 24.09.2013 um 12:41 hat Paolo Bonzini geschrieben:
> Il 20/09/2013 16:01, Benoît Canet ha scritto:
> >> > +    if (error_is_set(&local_err)) {
> >> > +        error_propagate(errp, local_err);
> >> > +        goto fail;
> > There is nothing to execute between error_propagate and fail: maybe we could
> > get rid of the goto.
> 
> Or perhaps of the "else".

Indeed, that looks a bit strange now... It doesn't survive until the end
of the series anyway, but I can remove it here. (The else branch has a
useless goto as well, but I'd prefer to leave it there in case new code
is added later - it's easy to miss when a goto becomes necessary.)

Kevin