Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix test case 059

[Fam Zheng]

On Tue, 09/24 14:49, Stefan Hajnoczi wrote:
> On Tue, Sep 24, 2013 at 10:49:33AM +0800, Fam Zheng wrote:
> > Since commit "block: Error parameter for open functions", error output
> > is more verbose. Update test case output file to follow the change.
> 
> This doesn't explain the "Formatting ..." trailing space change.
> 
> If this has changed, please split the change into a separate patch, with
> an explanation of when the space was introduced, and fix the other test
> case output files:
> 
> $ git grep '^Formatting' | grep '[^ ]$'
> 017.out:Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=6442450944
> 018.out:Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=6442450944
> 048.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824
> 059.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
> 059.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
> 059.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
> 063.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=4194304
> 063.out:Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=2097152

Not sure how it's introduced, it is actually ignored when comparing because we
have "-w" for diff command. I'll drop the spaces here and send another
revision, I'd like focus this series for fixing vmdk and leave the space clean
up for another series (if necessary).

Fam