[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 15/20] block: vhdx - fix comment typos in header,
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PATCH v6 15/20] block: vhdx - fix comment typos in header, fix incorrect struct fields |
Date: |
Wed, 25 Sep 2013 17:03:00 -0400 |
VHDXPage83Data and VHDXParentLocatorHeader both incorrectly had their
MSGUID fields set as arrays of 16. This is incorrect (it stems from
an early version where those fields were uint_8 arrays). Those fields
were, up to this patch, unused.
Also, there were a couple of typos and incorrect wording in comments,
and those have been fixed up as well.
Signed-off-by: Jeff Cody <address@hidden>
---
block/vhdx.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.h b/block/vhdx.h
index d35345d..c2ba697 100644
--- a/block/vhdx.h
+++ b/block/vhdx.h
@@ -58,7 +58,7 @@
typedef struct VHDXFileIdentifier {
uint64_t signature; /* "vhdxfile" in ASCII */
uint16_t creator[256]; /* optional; utf-16 string to identify
- the vhdx file creator. Diagnotistic
+ the vhdx file creator. Diagnostic
only */
} VHDXFileIdentifier;
@@ -114,8 +114,8 @@ typedef struct QEMU_PACKED VHDXHeader {
there is no valid log. If non-zero,
log entries with this guid are
valid. */
- uint16_t log_version; /* version of the log format. Mustn't
be
- zero, unless log_guid is also zero
*/
+ uint16_t log_version; /* version of the log format. Must be
+ set to zero */
uint16_t version; /* version of the vhdx file.
Currently,
only supported version is "1" */
uint32_t log_length; /* length of the log. Must be multiple
@@ -281,7 +281,7 @@ typedef struct QEMU_PACKED VHDXVirtualDiskSize {
} VHDXVirtualDiskSize;
typedef struct QEMU_PACKED VHDXPage83Data {
- MSGUID page_83_data[16]; /* unique id for scsi devices that
+ MSGUID page_83_data; /* unique id for scsi devices that
support page 0x83 */
} VHDXPage83Data;
@@ -296,7 +296,7 @@ typedef struct QEMU_PACKED
VHDXVirtualDiskPhysicalSectorSize {
} VHDXVirtualDiskPhysicalSectorSize;
typedef struct QEMU_PACKED VHDXParentLocatorHeader {
- MSGUID locator_type[16]; /* type of the parent virtual disk. */
+ MSGUID locator_type; /* type of the parent virtual disk. */
uint16_t reserved;
uint16_t key_value_count; /* number of key/value pairs for this
locator */
--
1.8.3.1
- [Qemu-devel] [PATCH v6 05/20] block: vhdx - break endian translation functions out, (continued)
- [Qemu-devel] [PATCH v6 05/20] block: vhdx - break endian translation functions out, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 06/20] block: vhdx - update log guid in header, and first write tracker, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 07/20] block: vhdx code movement - move vhdx_close() above vhdx_open(), Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 08/20] block: vhdx - log parsing, replay, and flush support, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 09/20] block: vhdx - add region overlap detection for image files, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 10/20] block: vhdx - add log write support, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 11/20] block: vhdx write support, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 12/20] block: vhdx - remove BAT file offset bit shifting, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 13/20] block: vhdx - move more endian translations to vhdx-endian.c, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 14/20] block: vhdx - break out code operations to functions, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 15/20] block: vhdx - fix comment typos in header, fix incorrect struct fields,
Jeff Cody <=
- [Qemu-devel] [PATCH v6 16/20] block: vhdx - add .bdrv_create() support, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 18/20] block: qemu-iotests for vhdx, read sample dynamic image, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 17/20] block: qemu-iotests - add basic ability to use binary sample images, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 19/20] block: vhdx - update _make_test_img() to filter out vhdx options, Jeff Cody, 2013/09/25
- [Qemu-devel] [PATCH v6 20/20] block: qemu-iotests for vhdx, add write test support, Jeff Cody, 2013/09/25