|
| From: | Benoît Canet |
| Subject: | Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies. |
| Date: | Thu, 26 Sep 2013 18:16:55 +0200 |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> > +static void quorum_aio_bh(void *opaque)
> > +{
> > + QuorumAIOCB *acb = opaque;
> > + BDRVQuorumState *s = acb->bqs;
> > + int ret;
> > +
> > + ret = s->threshold <= acb->success_count ? 0 : -EIO;
>
> It would be very much preferable if you stored the actual error code
> instead of turning everything into -EIO.
I am turning everything into -EIO because multiple errors can happen at the same
time.
Best regards
Benoît
| [Prev in Thread] | Current Thread | [Next in Thread] |