[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v2 30/71] hw/ide/Kconfig: Add Kconfig file
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [v2 30/71] hw/ide/Kconfig: Add Kconfig file |
Date: |
Fri, 27 Sep 2013 13:22:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
Il 27/09/2013 13:11, Stefan Hajnoczi ha scritto:
> On Fri, Sep 27, 2013 at 04:30:51AM +0200, Ákos Kovács wrote:
>> diff --git a/hw/net/Kconfig b/hw/net/Kconfig
>> new file mode 100644
>> index 0000000..19ca549
>> --- /dev/null
>> +++ b/hw/net/Kconfig
>
> This should be a separate patch.
>
>> @@ -0,0 +1,74 @@
>> +menu "Network devices"
>> + config DP8393X
>> + bool
>> +
>> + config XEN_BACKEND
>> + bool
>
> Should all devices have a "depends on $BUS" so they can only be
> configured if the bus is also configured?
Yes, but DP8393X is not qdevified.
That said, XEN_BACKEND should be in hw/xen, not here.
Paolo
- [Qemu-devel] [v2 23/71] hw/char/Kconfig: Add Kconfig file, (continued)
- [Qemu-devel] [v2 23/71] hw/char/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 21/71] hw/audio/Kconfig: Add audio Kconfig, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 24/71] hw/core/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 25/71] hw/cpu/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 26/71] hw/display/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 27/71] hw/dma/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 28/71] hw/gpio/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 29/71] hw/i2c/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 30/71] hw/ide/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 31/71] hw/input/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 32/71] hw/intc/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 34/71] hw/misc/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 33/71] hw/isa/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 35/71] hw/mips/Kconfig: Add Kconfig for MIPS, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 36/71] hw/nvram/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 38/71] hw/pci-bridge/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26
- [Qemu-devel] [v2 37/71] hw/pci/Kconfig: Add Kconfig file, Ákos Kovács, 2013/09/26