qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] qcow2: Free allocated L2 cluster on error


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 2/3] qcow2: Free allocated L2 cluster on error
Date: Mon, 30 Sep 2013 11:48:55 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9

On 2013-09-27 16:54, Kevin Wolf wrote:
Am 25.09.2013 um 16:37 hat Max Reitz geschrieben:
If an error occurs in l2_allocate, the allocated (but unused) L2 cluster
should be freed.

Signed-off-by: Max Reitz <address@hidden>
---
  block/qcow2-cluster.c | 4 ++++
  1 file changed, 4 insertions(+)
This needs an update of the reference output for test case 026 (both for
-nocache and writethrough).
Yes, right.

Most of the changes look expected and good, like cluster leaks
disappearing. With -nocache, however, there are a few cases that failed
previously and result in successful writes now. It would be interesting
to see the explanation for these before we merge the patch.
I personally don't see this cases. Could you give an example?

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]