[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs |
Date: |
Mon, 30 Sep 2013 19:38:04 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> writes:
> On Mon, Sep 30, 2013 at 05:49:26PM +0200, Markus Armbruster wrote:
>> Peter Maydell <address@hidden> writes:
>>
>> > On 30 September 2013 23:40, Michael S. Tsirkin <address@hidden> wrote:
>> >> diff --git a/include/qapi/error.h b/include/qapi/error.h
>> >> index 7d4c696..b85e996 100644
>> >> --- a/include/qapi/error.h
>> >> +++ b/include/qapi/error.h
>> >> @@ -13,14 +13,15 @@
>> >> #define ERROR_H
>> >>
>> >> #include "qemu/compiler.h"
>> >> +#include "qemu/typedefs.h"
>> >> #include "qapi-types.h"
>> >> #include <stdbool.h>
>> >>
>> >> /**
>> >> - * A class representing internal errors within QEMU. An error has a
>> >> ErrorClass
>> >> + * Error:
>> >> + * An object representing internal errors within QEMU. An error has a
>> >> ErrorClass
>> >> * code and a human message.
>> >> */
>> >> -typedef struct Error Error;
>> >
>> > Does the process-doc-comments tool really cope with documentation comments
>> > that are completely separate from the typedef like this?
>>
>> Even if they do, I don't.
>
> What kind of error do you encounter?
Even if $magic-tool could somehow find the documentation comments even
when they're far from the definitions they apply to, non-magic old me
can't.
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, (continued)
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Igor Mammedov, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Igor Mammedov, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Peter Maydell, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Andreas Färber, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Markus Armbruster, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Markus Armbruster, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs,
Markus Armbruster <=
[Qemu-devel] [PATCH v6 06/26] loader: support for unmapped ROM blobs, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 07/26] pcie_host: expose UNMAPPED macro, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 08/26] pcie_host: expose address format, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 09/26] q35: use macro for MCFG property name, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 10/26] q35: expose mmcfg size as a property, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 12/26] acpi: add rules to compile ASL source, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 11/26] i386: add ACPI table files from seabios, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 14/26] acpi: ssdt pcihp: updat generated file, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 15/26] loader: use file path size from fw_cfg.h, Michael S. Tsirkin, 2013/09/29
[Qemu-devel] [PATCH v6 13/26] acpi: pre-compiled ASL files, Michael S. Tsirkin, 2013/09/29