[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array
|
From: |
Fabien Chouteau |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array |
|
Date: |
Tue, 01 Oct 2013 16:28:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 |
On 10/01/2013 04:00 AM, Richard Henderson wrote:
> On 09/30/2013 08:57 AM, Fabien Chouteau wrote:
>> +extern const MonitorDef arch_monitor_defs[];
>
> This is supplied by target-foo/monitor.c, right?
> Why in the world is it declared in generic code?
>
Yes, why?
> Especially if it's only ever accessed via the
> cpu->monitor_defs member?
>
To begin with, I though I'd put in in each target-*/cpu.c, then having
it at only one place seemed more clean. I'm open to any suggestion.
--
Fabien Chouteau