Re: [Qemu-devel] [PATCH 2/2] .gitmodules: use upstream SeaBIOS repo to fix submodule init

[Peter Maydell]

On 3 October 2013 17:58,  <address@hidden> wrote:
> From: Alex Bennée <address@hidden>
>
> Currently master is broken as the wanted commit doesn't exist in
> qemu's mirror of SeaBIOS.
> ---
>  .gitmodules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitmodules b/.gitmodules
> index d7e3f3c..d5d5417 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -3,7 +3,7 @@
>         url = git://git.qemu.org/vgabios.git/
>  [submodule "roms/seabios"]
>         path = roms/seabios
> -       url = git://git.qemu.org/seabios.git/
> +       url = git://git.seabios.org/seabios.git

This is wrong. QEMU's submodules should all point to
git.qemu.org. Among other things our release source
tarballs pull in the sources and it's a good way to ensure
it's all consistent and we definitely have version controlled
copies of the sources we release under our control rather
than just in an external repo.

What should actually happen is that Anthony should fix
his workflow to ensure that he doesn't commit patches
which update submodules without also updating the
qemu.org mirrors of the external repos :-)

-- PMM