[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv4 04/17] block: introduce bdrv_has_discard_zeroes an
From: |
Peter Lieven |
Subject: |
[Qemu-devel] [PATCHv4 04/17] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes |
Date: |
Tue, 8 Oct 2013 13:57:58 +0200 |
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Peter Lieven <address@hidden>
---
block.c | 29 +++++++++++++++++++++++++++++
include/block/block.h | 2 ++
include/block/block_int.h | 13 +++++++++++++
3 files changed, 44 insertions(+)
diff --git a/block.c b/block.c
index 0675257..6a46bc2 100644
--- a/block.c
+++ b/block.c
@@ -3085,6 +3085,35 @@ int bdrv_has_zero_init(BlockDriverState *bs)
return 0;
}
+bool bdrv_has_discard_zeroes(BlockDriverState *bs)
+{
+ assert(bs->drv);
+
+ if (bs->backing_hd) {
+ return false;
+ }
+ if (bs->drv->bdrv_has_discard_zeroes) {
+ return bs->drv->bdrv_has_discard_zeroes(bs);
+ }
+
+ return false;
+}
+
+bool bdrv_has_discard_write_zeroes(BlockDriverState *bs)
+{
+ assert(bs->drv);
+
+ if (bs->backing_hd || !(bs->open_flags & BDRV_O_UNMAP)) {
+ return false;
+ }
+
+ if (bs->drv->bdrv_has_discard_write_zeroes) {
+ return bs->drv->bdrv_has_discard_write_zeroes(bs);
+ }
+
+ return false;
+}
+
typedef struct BdrvCoGetBlockStatusData {
BlockDriverState *bs;
BlockDriverState *base;
diff --git a/include/block/block.h b/include/block/block.h
index b72c81a..2de226f 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -310,6 +310,8 @@ int bdrv_discard(BlockDriverState *bs, int64_t sector_num,
int nb_sectors);
int bdrv_co_discard(BlockDriverState *bs, int64_t sector_num, int nb_sectors);
int bdrv_has_zero_init_1(BlockDriverState *bs);
int bdrv_has_zero_init(BlockDriverState *bs);
+bool bdrv_has_discard_zeroes(BlockDriverState *bs);
+bool bdrv_has_discard_write_zeroes(BlockDriverState *bs);
int64_t bdrv_get_block_status(BlockDriverState *bs, int64_t sector_num,
int nb_sectors, int *pnum);
int bdrv_is_allocated(BlockDriverState *bs, int64_t sector_num, int nb_sectors,
diff --git a/include/block/block_int.h b/include/block/block_int.h
index f95dba7..ce5c62e 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -217,6 +217,19 @@ struct BlockDriver {
*/
int (*bdrv_has_zero_init)(BlockDriverState *bs);
+ /*
+ * Returns true if discarded blocks read back as zeroes.
+ */
+ bool (*bdrv_has_discard_zeroes)(BlockDriverState *bs);
+
+ /*
+ * Returns true if the driver can optimize writing zeroes by discarding
+ * sectors. It is additionally required that the block device is
+ * opened with BDRV_O_UNMAP and the that write zeroes request carries
+ * the BDRV_REQ_MAY_UNMAP flag for this to work.
+ */
+ bool (*bdrv_has_discard_write_zeroes)(BlockDriverState *bs);
+
QLIST_ENTRY(BlockDriver) list;
};
--
1.7.9.5
- [Qemu-devel] [PATCHv4 00/17] block: logical block provisioning enhancements, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 05/17] block/raw: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 03/17] block: introduce BDRV_REQ_MAY_UNMAP request flag, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 01/17] block: make BdrvRequestFlags public, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 02/17] block: add flags to bdrv_*_write_zeroes, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 08/17] block: honour BlockLimits in bdrv_co_discard, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 06/17] block: add BlockLimits structure to BlockDriverState, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 07/17] block: honour BlockLimits in bdrv_co_do_write_zeroes, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 09/17] iscsi: simplify iscsi_co_discard, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 11/17] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 04/17] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes,
Peter Lieven <=
- [Qemu-devel] [PATCHv4 10/17] iscsi: set limits in BlockDriverState, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/08
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/18
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Paolo Bonzini, 2013/10/18
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/18