[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually
From: |
Marcelo Tosatti |
Subject: |
Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually |
Date: |
Tue, 8 Oct 2013 18:51:55 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Oct 08, 2013 at 10:03:48AM +0200, Paolo Bonzini wrote:
> Il 08/10/2013 02:41, Marcelo Tosatti ha scritto:
> > + /* unblock SIGBUS */
> > + pthread_sigmask(SIG_BLOCK, NULL, &oldset);
> > + sigemptyset(&set);
> > + sigaddset(&set, SIGBUS);
> > + pthread_sigmask(SIG_UNBLOCK, &set, NULL);
>
> Please instead modify qemu-thread-posix.c to unblock all per-thread
> signals (SIGBUS, SIGSEGV, SIGILL, SIGFPE and SIGSYS). There is no need
> to keep those blocked.
>
> Paolo
main-loop.c handles SIGBUS via signalfd to emulate MCEs (associated
commits). Therefore it must be blocked.
Note that what this patch does it to maintain the signal handling state
(it saves the previous state, modifies state, restores previous state) so
that its unchanged.
- [Qemu-devel] [patch 0/2] force -mem-path RAM allocation, Marcelo Tosatti, 2013/10/07
- [Qemu-devel] [patch 2/2] qemu: add -mem-path-force option to force RAM allocation via -mem-path, Marcelo Tosatti, 2013/10/07
- [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually, Marcelo Tosatti, 2013/10/07
- Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually, Paolo Bonzini, 2013/10/08
- Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually,
Marcelo Tosatti <=
- Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually, Paolo Bonzini, 2013/10/09
- Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually, Marcelo Tosatti, 2013/10/09
- Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually, Paolo Bonzini, 2013/10/09
- Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually, Paolo Bonzini, 2013/10/10
- Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually, Marcelo Tosatti, 2013/10/10
Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually, Paolo Bonzini, 2013/10/28
Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually, Peter Maydell, 2013/10/28
Re: [Qemu-devel] [patch 0/2] force -mem-path RAM allocation, Markus Armbruster, 2013/10/08