qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet
Date: Wed, 9 Oct 2013 11:01:00 +0300

On Wed, Oct 09, 2013 at 09:41:29AM +0200, Paolo Bonzini wrote:
> Il 09/10/2013 09:24, Michael S. Tsirkin ha scritto:
> >> > Sorry, out of office for a long time, and did not keep up with this
> >> > thread in time.
> >> > When letting the caller set the intcap, we should consider the
> >> > compatibility of q35. For pc-q35-1.7 or later, the caller should set
> >> > the property, otherwise not.
> > Set it always - just set it to a compatible value for 1.6.
> > 
> 
> So you're suggesting skipping the mechanism we have for compatibility
> properties, and instead using a global variable or something like that?
> 
> Paolo

That's one option.
Or we can use global properties - just set for 1.7 too.

All this is not ideal: properties really need to
integrate better with QOM, and using global
properties for compat always was a hack.


-- 
MST



reply via email to

[Prev in Thread] Current Thread [Next in Thread]