Re: [Qemu-devel] [PATCH 2/4] vring: factor common code for error exits

[Paolo Bonzini]

Il 10/10/2013 22:53, Richard Henderson ha scritto:
> On 10/10/2013 08:07 AM, Paolo Bonzini wrote:
>>      return head;
>> +
>> +out:
>> +    assert(ret < 0);
>> +    if (ret == -EFAULT) {
>> +        vring->broken = true;
>> +    }
>> +    return ret;
> 
> If this is only the error path, can we call the
> label something other than "out"?

Yes.  Though I think it does not matter if the function returns a zero
or positive result after the next patch, so it can become a general exit
label too.

Paolo