[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/2] vmdk: convert error reporting
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/2] vmdk: convert error reporting |
Date: |
Fri, 11 Oct 2013 12:03:29 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 11.10.2013 um 09:43 hat Fam Zheng geschrieben:
> The first patch converts "fprintf(stderr,..." to error_setg with errp, and
> fixes style of error message texts.
>
> The second patch checks the compatibility of zeroed_grain flag and flat type
> and reports error if both are true.
>
> v3: Update qemu-iotests.
>
> v2: [01] More conversion of error messages, also catch error from
> bdrv_{pread,pwrite} with error_setg_errno.
>
> Fam Zheng (2):
> vmdk: convert error code to use errp
> vmdk: refuse enabling zeroed grain with flat images
Thanks, applied both to the block branch.
There are still (q)error_report calls in vmdk_open_vmdk4(), as well as
an error return without a message. The latter also happens in
vmdk_open_sparse(), vmdk_open_desc_file() vmdk_open() and vmdk_create().
This can be addressed in a follow-up series.
Kevin