[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete |
Date: |
Tue, 15 Oct 2013 10:23:24 +0800 |
There is errp passed in, so no need for local_err and error_propagate.
Also drop the backing_filename which is set but unused since 34b5d2c.
Signed-off-by: Fam Zheng <address@hidden>
--
v2: fix typo in subject line.
drop backing_filename.
(Thanks Eric)
Signed-off-by: Fam Zheng <address@hidden>
---
block/mirror.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 7b95acf..7a73022 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -505,15 +505,10 @@ static void mirror_iostatus_reset(BlockJob *job)
static void mirror_complete(BlockJob *job, Error **errp)
{
MirrorBlockJob *s = container_of(job, MirrorBlockJob, common);
- Error *local_err = NULL;
int ret;
- ret = bdrv_open_backing_file(s->target, NULL, &local_err);
+ ret = bdrv_open_backing_file(s->target, NULL, errp);
if (ret < 0) {
- char backing_filename[PATH_MAX];
- bdrv_get_full_backing_filename(s->target, backing_filename,
- sizeof(backing_filename));
- error_propagate(errp, local_err);
return;
}
if (!s->synced) {
--
1.8.3.1
- [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete, Eric Blake, 2013/10/14
- Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete, Max Reitz, 2013/10/16
- Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete, Stefan Hajnoczi, 2013/10/17
- Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete, Kevin Wolf, 2013/10/17
- Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete, Fam Zheng, 2013/10/18
- Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete, Max Reitz, 2013/10/18
- Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete, Kevin Wolf, 2013/10/19
- Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete, Max Reitz, 2013/10/19
- Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete, Paolo Bonzini, 2013/10/19