Re: [Qemu-devel] [PATCH v2] pseries: Update SLOF firmware image

[Alexander Graf]

Am 16.10.2013 um 12:47 schrieb Alexey Kardashevskiy <address@hidden>:

> On 10/16/2013 08:54 PM, Alexander Graf wrote:
>> On 10/15/2013 07:00 AM, Alexey Kardashevskiy wrote:
>>> SLOF git commit is e2e8ac901e617573ea383f9cffd136146d0675a4
>>> 
>>> The main changes are:
>>> * fixed bug with not passing arguments from -append
>>> * client-architecture-support hypercall
>>> * netboot
>>> * USB stack fixes
>>> 
>>> The full list of changes:
>>>> client-architecture-support: fix wrong version read
>>>> client-architecture-support: fix redundant stack drop
>>>> Update device tree returned by CAS hypercall
>>>> fdt: introduce fdt-init
>>>> Add ibm,client-architecture-support method
>>>> Kernel parameter passed from qemu commandline ignored
>>>> Allow more than one client to open net devices simultaneously
>>>> ci: add missing close in else condition
>>>> Add GPT support
>>>> pci: fix interrupt-map for bridges
>>>> usb-ohci: preserve the toggleCarry bit in ED
>>>> usb-ohci: done_head processing fixes
>>>> usb-ohci: update init and rationalize timings
>>>> usb-msc: handle stall and other fixes
>>>> scsi: make probe more error resilient
>>>> usb-core: Add CLEAR FEATURE api
>>>> Implement range allocator
>>>> Remove bcm57xx network driver as module
>>>> Remove e1000 network driver as module
>>>> Remove virtio-net network driver as module
>>>> Remove veth network driver as module
>>>> Add missing close-dev in ping
>>>> Remove lodable network driver modules and related functions
>>>> Add bcm57xx network driver in libbcm
>>>> Add e1000 network driver in libe1k
>>>> Add virtio-net driver in libvirtio
>>>> Add veth driver in libveth
>>>> Get MAC address for client interface module
>>>> Add SLOF usleep wrapper
>>>> Add SLOF pci wrapper functions
>>>> Fix 'canon' client interface
>>> 
>>> Cc: Nikunj A Dadhania <address@hidden>
>>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>>> ---
>>> Changes:
>>> v2:
>>> * fixed a bug in "client-architecture-support: fix wrong version read"
>>> 
>>> ---
>>> 
>>> Alex, please note that the patch is made against your "ppc-next" branch
>>> rather than qemu.org/master as the previous SLOF update request did not
>>> reach upstream yet.
>>> 
>>> And yes, this is v2. My bad, sorry, the updates are huge for email :(
>>> ---
>>>  pc-bios/README   |   2 +-
>>>  pc-bios/slof.bin | Bin 875424 -> 873920 bytes
>>>  roms/SLOF        |   2 +-
>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/pc-bios/README b/pc-bios/README
>>> index cf97365..e2622d2 100644
>>> --- a/pc-bios/README
>>> +++ b/pc-bios/README
>>> @@ -17,7 +17,7 @@
>>>  - SLOF (Slimline Open Firmware) is a free IEEE 1275 Open Firmware
>>>    implementation for certain IBM POWER hardware.  The sources are at
>>>    https://github.com/aik/SLOF, and the image currently in qemu is
>>> -  built from git tag qemu-slof-20130827.
>>> +  built from git tag qemu-slof-20131015.
>>>    - sgabios (the Serial Graphics Adapter option ROM) provides a means for
>>>    legacy x86 software to communicate with an attached serial console as
>>> diff --git a/pc-bios/slof.bin b/pc-bios/slof.bin
>>> index
>>> 0e8b51ad1f3ecde581db2a49c1b75e96e9084c41..92a9831be7ade3d09a8b0aea08d0694da792da51
>>> 100644
>>> GIT binary patch
>>> delta 238635
>> 
>> [...]
>> 
>>> diff --git a/roms/SLOF b/roms/SLOF
>>> index a523d1b..e2e8ac9 160000
>>> --- a/roms/SLOF
>>> +++ b/roms/SLOF
>>> @@ -1 +1 @@
>>> -Subproject commit a523d1b0cd6e96cf5e393f0a10f897e8ed639fdc
>>> +Subproject commit e2e8ac901e617573ea383f9cffd136146d0675a4
>> 
>> Is this commit in git.qemu.org/SLOF.git? I can't find it there.
> 
> It is from git in pc-bios/README so it is my git on github. I do not have
> authority over git.qemu.org :)

Well, the submodule points to the copy on git.qemu.org for legal reasons. So I 
can only include this after Anthony updated it :)

Alex

> 
> 
>> Anthony, can you pull it?
> 
> 
> 
> 
> 
> -- 
> Alexey