qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/13] qapi: move MonitorEvent define


From: Wenchao Xia
Subject: Re: [Qemu-devel] [PATCH 03/13] qapi: move MonitorEvent define
Date: Mon, 21 Oct 2013 10:44:50 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1

于 2013/10/18 20:38, Eric Blake 写道:
On 10/18/2013 03:36 AM, Paolo Bonzini wrote:
Il 18/10/2013 03:11, Wenchao Xia ha scritto:
Signed-off-by: Wenchao Xia <address@hidden>
---
  include/monitor/monitor.h |   38 +-------------------------
  include/qapi/qmp/qevent.h |   66 +++++++++++++++++++++++++++++++++++++++++++++
  include/qapi/qmp/types.h  |    1 +
  3 files changed, 68 insertions(+), 37 deletions(-)
  create mode 100644 include/qapi/qmp/qevent.h
Please move it qemu-schema.json instead.
qapi-schema.json, but yes, I agree that declaring it as a qapi enum and
letting the code generator create the constants, rather than moving the
hand-maintained constants into a new header, is smarter.

   I will try use qapi-schema.json in next version.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]