Re: [Qemu-devel] [PATCH 02/10] sysbus: Set cannot_instantiate_with_device_add_yet

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> On 17 October 2013 14:54,  <address@hidden> wrote:
>> From: Markus Armbruster <address@hidden>
>>
>> device_add plugs devices into suitable bus.  For "real" buses, that
>> actually connects the device.  For sysbus, the connections need to be
>> made separately, and device_add can't do that.  The device would be
>> left unconncected, and could not possibly work.
>
> "unconnected"

Will fix.

>> Many, but not all sysbus devices alreasy set
>
> "already"

Will fix.

>> cannot_instantiate_with_device_add_yet in their class init function.
>>
>> Set it in their abstract base's class init function
>> sysbus_device_class_init(), and remove the now redundant assignments
>> from device class init functions.
>
> So I think this change is probably OK (but see my comments on
> patch 1 about what our definition of the flag is supposed to be).
> But I'd like to see a list of the devices which this patch makes no-user
> which previously weren't. Then I could eyeball the list and check
> whether there's anything in it which shouldn't be.

I'll include that list in v2.

Thanks!