[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 5/6] target-arm: fix sorting issue of KVM cpreg list
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 5/6] target-arm: fix sorting issue of KVM cpreg list |
Date: |
Fri, 25 Oct 2013 19:07:28 +0100 |
From: Alvise Rigo <address@hidden>
The compare_u64 function was not sorting the KVM cpreg_list in the
right way due to the wrong returned value. Since we are comparing
two 64bit values we can't simply return their difference if the
returned type is int.
Signed-off-by: Alvise Rigo <address@hidden>
Message-id: address@hidden
[PMM: fixed coding style, indent and commit message formatting]
Signed-off-by: Peter Maydell <address@hidden>
---
target-arm/kvm.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/target-arm/kvm.c b/target-arm/kvm.c
index b92e00d..6e5cd36 100644
--- a/target-arm/kvm.c
+++ b/target-arm/kvm.c
@@ -67,7 +67,13 @@ static bool reg_syncs_via_tuple_list(uint64_t regidx)
static int compare_u64(const void *a, const void *b)
{
- return *(uint64_t *)a - *(uint64_t *)b;
+ if (*(uint64_t *)a > *(uint64_t *)b) {
+ return 1;
+ }
+ if (*(uint64_t *)a < *(uint64_t *)b) {
+ return -1;
+ }
+ return 0;
}
int kvm_arch_init_vcpu(CPUState *cs)
--
1.7.9.5
- [Qemu-devel] [PULL 0/6] target-arm queue, Peter Maydell, 2013/10/25
- [Qemu-devel] [PULL 5/6] target-arm: fix sorting issue of KVM cpreg list,
Peter Maydell <=
- [Qemu-devel] [PULL 2/6] hw/arm: Tidy up conditional calls to arm_load_kernel, Peter Maydell, 2013/10/25
- [Qemu-devel] [PULL 4/6] target-arm: sort TCG cpreg list by KVM-style 64 bit ID number, Peter Maydell, 2013/10/25
- [Qemu-devel] [PULL 1/6] hw/arm/boot: Make user not specifying a kernel not an error, Peter Maydell, 2013/10/25
- [Qemu-devel] [PULL 6/6] integrator: fix Linux boot failure by emulating dbg region, Peter Maydell, 2013/10/25
- [Qemu-devel] [PULL 3/6] target-arm: Add CP15 VBAR support, Peter Maydell, 2013/10/25
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Edgar E. Iglesias, 2013/10/31