[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 5/6] blkdebug: add debug events for snapshot
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH V4 5/6] blkdebug: add debug events for snapshot |
Date: |
Sat, 02 Nov 2013 14:20:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
On 14.10.2013 23:52, Wenchao Xia wrote:
> Some code in qcow2-snapshot.c directly access bs->file, so in those
s/access/accesses/
> points error can't be injected by other events. Since the code in
Perhaps "places" instead of "points"? (And s/error/errors/)
> qcow2-snapshot.c is qcow2's internal detail similar as L1 table,
Maybe something like "qcow2-snapshot.c is similar to the other qcow2
internal code (in regards to e.g. the L1 table)" would be easier to
parse, although I'm not sure whether it has the same meaning you wanted
to convey.
> so add some debug events.
Maybe remove the "so", because you already had a "since" in the previous
subordinate clause?
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
Aside from that: Reviewed-by: Max Reitz <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH V4 5/6] blkdebug: add debug events for snapshot,
Max Reitz <=