[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss |
Date: |
Mon, 4 Nov 2013 19:11:44 +0000 |
On 4 November 2013 18:55, Petar Jovanovic <address@hidden> wrote:
> I am not sure I understand your point. This used to be all in one file, now
> it is divided in arch-specific files that can be later populated with other
> target specific struct definitions. This was also suggested in the first
> review a month ago.
Yeah, the idea is to keep target-specifics separate and
also to make it obvious (as in compile-failure) when a
structure needs to be created or checked for a new target.
Where the kernel has a "common" struct that targets can
opt into via #defining something we can do the same, of
course.
(That said, the necessity for #ifdefs in the functions
which do the byteswapping of fields is a bit ugly. I meant
to look into whether that could be avoided somehow...)
-- PMM