Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default

[Anthony Liguori]

Gerd Hoffmann <address@hidden> writes:

> On So, 2013-11-03 at 08:45 -0800, Anthony Liguori wrote:
>> Modern Linux's no longer support /dev/dsp so enabling it by
>> default causes audio failures on newer Linux distros.
>
> That will break sound on BSD.
>
> I think we should do something like this instead:
>
> --- a/configure
> +++ b/configure
> @@ -554,7 +554,7 @@ Haiku)
>    LIBS="-lposix_error_mapper -lnetwork $LIBS"
>  ;;
>  *)
> -  audio_drv_list="oss"
> +  audio_drv_list="pa alsa oss"
>    audio_possible_drivers="oss alsa sdl esd pa"
>    linux="yes"
>    linux_user="yes"
>
> i.e. build pulseaudio and alsa by default on linux and prioritize them
> over oss.

This patch just requires that you explicitly select oss so it's not
breaking audio on BSD.

Since the oss code can fail to initialize without handling it
gracefully, it really cannot be default on any platform.

Same problem would occur on BSD if the permissions on /dev/dsp were
restrictive.

Regards,

Anthony Liguori

>
> cheers,
>   Gerd