Re: [Qemu-devel] [PATCH] block: Save errno before error_setg_errno

[Stefan Hajnoczi]

On Tue, Nov 05, 2013 at 12:26:41PM -0700, Eric Blake wrote:
> On 11/05/2013 12:03 PM, Max Reitz wrote:
> > error_setg_errno() may overwrite errno; therefore, its value should be
> > read before calling that function and not afterwards.
> > 
> > Signed-off-by: Max Reitz <address@hidden>
> > ---
> >  block.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Eric Blake <address@hidden>
> 
> Still, wouldn't it be easier to patch error_setg_errno (and friends) to
> guarantee that errno is unchanged on exit compared to its value on
> entrance, rather than having to audit for other mistakes like this?

Agreed, that can be done as a separate patch.

Stefan