[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect i
From: |
Corey Minyard |
Subject: |
Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected |
Date: |
Tue, 12 Nov 2013 11:08:07 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/12/2013 10:43 AM, Eric Blake wrote:
> On 11/12/2013 09:33 AM, Corey Minyard wrote:
>> Allow a socket that connects to reconnect on a periodic basis if it
>> fails to connect at startup or if the connection drops while in use.
>>
>> Signed-off-by: Corey Minyard <address@hidden>
>> ---
>> include/sysemu/char.h | 3 ++
>> qemu-char.c | 88
>> ++++++++++++++++++++++++++++++++++++++++++++-------
>> qemu-options.hx | 11 +++++--
>> 3 files changed, 87 insertions(+), 15 deletions(-)
>>
>> +++ b/qemu-options.hx
>> @@ -1780,8 +1780,9 @@ ETEXI
>> DEF("chardev", HAS_ARG, QEMU_OPTION_chardev,
>> "-chardev null,id=id[,mux=on|off]\n"
>> "-chardev
>> socket,id=id[,host=host],port=host[,to=to][,ipv4][,ipv6][,nodelay]\n"
>> - " [,server][,nowait][,telnet][,mux=on|off] (tcp)\n"
>> - "-chardev
>> socket,id=id,path=path[,server][,nowait][,telnet],[mux=on|off] (unix)\n"
>> + " [,server][,nowait][,telnet][,mux=on|off][,reconnect=seconds]
>> (tcp)\n"
>> + "-chardev
>> socket,id=id,path=path[,server][,nowait][,telnet][,mux=on|off]\n"
>> + " [,reconnect=seconds] (unix)\n"
>> address@hidden specifies that if the socket does not come up at startup,
>> +or if the socket is closed for some reason (like the other end exited),
>> +wait the given number of seconds and attempt to reconnect.
> Sounds cool. Are you planning on also adding the QMP counterpart for
> specifying this option when doing hotplugs of a chardev?
Yes, I need to add that.
> Does reconnect
> make any sense when not using server mode?
>
Actually, it only really makes sense when in client mode. The option
currently won't do anything in server mode. I can't see a use for it in
server mode, it doesn't know where to connect.
-corey
[Qemu-devel] [PATCH 05/16] Add a base IPMI interface, Corey Minyard, 2013/11/12
[Qemu-devel] [PATCH 07/16] ipmi: Add a KCS low-level interface, Corey Minyard, 2013/11/12
[Qemu-devel] [PATCH 06/16] ipmi: Add a PC ISA type structure, Corey Minyard, 2013/11/12
[Qemu-devel] [PATCH 08/16] ipmi: Add a BT low-level interface, Corey Minyard, 2013/11/12
[Qemu-devel] [PATCH 10/16] ipmi: Add an external connection simulation interface, Corey Minyard, 2013/11/12