[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helpe
|
From: |
Avi Kivity |
|
Subject: |
Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper |
|
Date: |
Tue, 12 Nov 2013 21:27:29 +0200 |
On Nov 12, 2013 9:23 PM, "Eric Blake" <address@hidden> wrote:
>
> On 11/12/2013 04:10 AM, Avi Kivity wrote:
> > Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper since
> > it doesn't have the required capabilities.
> >
> > Fix by adding them.
> >
> > Note: this may break installing as non-root. This is actually the right
> > thing to do, since not setting up the capability would result in a broken
> > setup. Perhaps we need a configure flag to disable helpers.
> >
>
> > +++ b/rules.mak
> > @@ -177,3 +177,5 @@ $(shell mkdir -p $(sort $(foreach var,$(nested-vars),$(dir $($(var))))))
> > $(foreach var,$(nested-vars), $(eval \
> > -include $(addsuffix *.d, $(sort $(dir $($(var)))))))
> > endef
> > +
> > +SETCAP = setcap
> > \ No newline at end of file
>
> Is this intentional?
No.
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>