[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-iotests: Use cache=writeback in drive_add
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-iotests: Use cache=writeback in drive_add |
Date: |
Wed, 13 Nov 2013 14:39:09 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 13.11.2013 um 13:27 hat Fam Zheng geschrieben:
> This will allow running iotests on tmpfs, which is much faster, so we
> can run more tests.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index fb10ff4..c29314a 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -96,7 +96,7 @@ class VM(object):
> '''Add a virtio-blk drive to the VM'''
> options = ['if=virtio',
> 'format=%s' % imgfmt,
> - 'cache=none',
> + 'cache=writeback',
> 'file=%s' % path,
> 'id=drive%d' % self._num_drives]
> if opts:
Well, in fact any fixed value is wrong here. By default, qemu-iotests is
supposed to use cache=writethrough for everything, and ./check -nocache
should make it cache=none. I think what we really want is a ./check
option that allows specifying any cache option, and then we should make
the scripts honour that option.
Kevin