[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] mirror: Check for bdrv_get_info result
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] mirror: Check for bdrv_get_info result |
Date: |
Wed, 13 Nov 2013 10:34:51 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Nov 13, 2013 at 08:53:14AM +0800, Fam Zheng wrote:
> bdrv_get_info could fail. Add check before using the returned value.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/mirror.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index 7b95acf..c0c321b 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -320,8 +320,8 @@ static void coroutine_fn mirror_run(void *opaque)
> bdrv_get_backing_filename(s->target, backing_filename,
> sizeof(backing_filename));
> if (backing_filename[0] && !s->target->backing_hd) {
> - bdrv_get_info(s->target, &bdi);
> - if (s->granularity < bdi.cluster_size) {
> + ret = bdrv_get_info(s->target, &bdi);
> + if (ret == 0 && s->granularity < bdi.cluster_size) {
For ret < 0, I think we should exit on error (at least in cases where
ret < 0 && ret != -ENOTSUP).
> s->buf_size = MAX(s->buf_size, bdi.cluster_size);
> s->cow_bitmap = bitmap_new(length);
> }
[Qemu-devel] [PATCH 2/5] vmdk: Implement .bdrv_write_compressed, Fam Zheng, 2013/11/12
[Qemu-devel] [PATCH 3/5] block: Change BlockDriverInfo.cluster_size to 64 bits, Fam Zheng, 2013/11/12
[Qemu-devel] [PATCH 4/5] vmdk: Implement .bdrv_get_info(), Fam Zheng, 2013/11/12
[Qemu-devel] [PATCH 5/5] mirror: Check for bdrv_get_info result, Fam Zheng, 2013/11/12
- Re: [Qemu-devel] [PATCH 5/5] mirror: Check for bdrv_get_info result,
Jeff Cody <=