[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/i386/Makefile.obj: use $(PYTHON) to run .py
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH] hw/i386/Makefile.obj: use $(PYTHON) to run .py scripts consistently |
Date: |
Sat, 16 Nov 2013 11:19:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
Am 16.11.2013 11:14, schrieb Michael Tokarev:
> $(PYTHON) is a Make variable which is set by configure.
> In all other places over the tree, .py files are run from
> Makefiles using this variable, except of a single leftover
> in hw/i386/Makefile.obj (and a nearby place in there uses
> $(PYTHON) correctly). Fix this leftover too.
>
> Signed-off-by: Michael Tokarev <address@hidden>
> Cc: Luigi Rizzo <address@hidden>
> Cc: Stefan Weil <address@hidden>
>
> --
> mjt: I want to apply this to trivial-patches for-1.7
> ---
> hw/i386/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> index 185aacb..09ac433 100644
> --- a/hw/i386/Makefile.objs
> +++ b/hw/i386/Makefile.objs
> @@ -20,7 +20,7 @@ hw/i386/%.hex: $(SRC_PATH)/hw/i386/%.dsl
> $(SRC_PATH)/scripts/acpi_extract_prepro
> $(call quiet-command, cpp -P $< -o $*.dsl.i.orig, " CPP
> $(TARGET_DIR)$*.dsl.i.orig")
> $(call quiet-command, $(PYTHON)
> $(SRC_PATH)/scripts/acpi_extract_preprocess.py $*.dsl.i.orig > $*.dsl.i, "
> ACPI_PREPROCESS $(TARGET_DIR)$*.dsl.i")
> $(call quiet-command, $(IASL) $(call iasl-option,$(IASL),-Pn,) -vs -l
> -tc -p $* $*.dsl.i $(if $(V), , > /dev/null) 2>&1 ," IASL
> $(TARGET_DIR)$*.dsl.i")
> - $(call quiet-command, $(SRC_PATH)/scripts/acpi_extract.py $*.lst >
> $*.off, " ACPI_EXTRACT $(TARGET_DIR)$*.off")
> + $(call quiet-command, $(PYTHON) $(SRC_PATH)/scripts/acpi_extract.py
> $*.lst > $*.off, " ACPI_EXTRACT $(TARGET_DIR)$*.off")
> $(call quiet-command, cat $*.off > $@, " CAT $(TARGET_DIR)$@")
> else
> #IASL Not present. Restore pre-generated hex files.
Reviewed-by: Stefan Weil <address@hidden>
Yes, this is a bug fix which should be included in QEMU 1.7.
Regards,
Stefan