[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] virtio-net: fix the memory leak in rxfilter_
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2] virtio-net: fix the memory leak in rxfilter_notify() |
Date: |
Mon, 18 Nov 2013 17:44:49 +0200 |
On Mon, Nov 18, 2013 at 11:32:17PM +0800, Amos Kong wrote:
> object_get_canonical_path() returns a gchar*, it should be freeed by the
> caller.
>
> Signed-off-by: Amos Kong <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
> ---
> v2: put gchar *path inside rxfilter_notify_enabled block
> ---
> hw/net/virtio-net.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 613f144..b75c753 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -200,16 +200,16 @@ static void rxfilter_notify(NetClientState *nc)
> VirtIONet *n = qemu_get_nic_opaque(nc);
>
> if (nc->rxfilter_notify_enabled) {
> + gchar *path = object_get_canonical_path(OBJECT(n->qdev));
> if (n->netclient_name) {
> event_data = qobject_from_jsonf("{ 'name': %s, 'path': %s }",
> - n->netclient_name,
> -
> object_get_canonical_path(OBJECT(n->qdev)));
> + n->netclient_name, path);
> } else {
> - event_data = qobject_from_jsonf("{ 'path': %s }",
> -
> object_get_canonical_path(OBJECT(n->qdev)));
> + event_data = qobject_from_jsonf("{ 'path': %s }", path);
> }
> monitor_protocol_event(QEVENT_NIC_RX_FILTER_CHANGED, event_data);
> qobject_decref(event_data);
> + g_free(path);
>
> /* disable event notification to avoid events flooding */
> nc->rxfilter_notify_enabled = 0;
> --
> 1.8.3.1