qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qemu-iotests: Add "-c <cache-mode>" to check


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Add "-c <cache-mode>" to check
Date: Tue, 19 Nov 2013 14:46:28 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On 2013年11月18日 23:38, Kevin Wolf wrote:
Am 18.11.2013 um 16:29 hat Stefan Hajnoczi geschrieben:
On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote:
The default cache mode for drive options is changed to writethrough, and
overridable with "./check -c <mode>".

Please make the default "writeback" so that ./check completes more
quickly.

Changing the cache mode should be a separate patch.

The current default for all shell script based tests is
cache=writethrough (can be overridden with -nocache) and Python test
cases should respect the same setting.

This is also the problem that I see with this patch: It doesn't make
'-nocache' an alias of '-c none', but both control different aspects.
What should happen is that '-c <mode>' sets

     QEMU_IO_OPTIONS="$QEMU_IO_OPTIONS -t <mode>"

like -nocache does today, and the Python scripts should refer to the
same cache settings as the bash scripts do.


Right. Thanks for explaining.

Fam




reply via email to

[Prev in Thread] Current Thread [Next in Thread]