Re: [Qemu-devel] [PATCH v2 0/2] Add cache mode option to qemu-iotests

[Kevin Wolf]

Am 19.11.2013 um 07:45 hat Fam Zheng geschrieben:
> The first patch adds "-c <mode>" option to ./check and convert "-nocache" to 
> an
> alias to "-c none". The mode is used in qemu-io.
> 
> The second patch modifies iotests.py to use the cache mode option in qemu 
> drive
> command line.

Okay, I gave it some testing, too, and it looks like we need some
additional changes. There are some test cases that use:

_unsupported_qemu_io_options --nocache

Which obviously doesn't work any more. We need to replace it by a check
against $CACHEMODE (or, perhaps preferably, even override it
automatically, so that test cases aren't left out just because of the
cache mode)

Test case 026 uses the option of having a 026.out.nocache, which differs
from the normal output. I suspect the correct differentiation is here
between writethrough and writeback modes. And of course, grepping for
'--nocache' to detect the condition doesn't work any more.

Kevin