Re: [Qemu-devel] [PATCH V5 3/5] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

[Wenchao Xia]

于 2013/11/19 19:29, Kevin Wolf 写道:
> Am 10.11.2013 um 23:03 hat Wenchao Xia geschrieben:
> > Signed-off-by: Wenchao Xia <address@hidden>
> > ---
> >   tests/qemu-iotests/058     |  102 ++++++++++++++++++++++++++++++++++++++++++++
> >   tests/qemu-iotests/058.out |   32 ++++++++++++++
> >   tests/qemu-iotests/check   |    1 +
> >   tests/qemu-iotests/group   |    1 +
> >   4 files changed, 136 insertions(+), 0 deletions(-)
> >   create mode 100755 tests/qemu-iotests/058
> >   create mode 100644 tests/qemu-iotests/058.out
>
> I think this should have:
>
> _supported_proto nbd
>
> Or otherwise the check in common needs to be changed. At least for me
> the test failed without an error message because I didn't have a
> qemu-nbd symlink in place.
>
> Kevin
  I found a little problem:
$QEMU_IMG snapshot -c sn1 "$TEST_IMG"
can't work when IMGPROTO=nbd, since in common.rc the image was not
exported as raw:

    if [ $IMGPROTO = "nbd" ]; then
        eval "$QEMU_NBD -v -t -b 127.0.0.1 -p 10810  $TEST_IMG_FILE &"
        QEMU_NBD_PID=$!
        sleep 1 # FIXME: qemu-nbd needs to be listening before we continue
    fi

So later the test case think $TEST_IMG as a raw image. All case used
$QEMU_IMG snapshot will fail, such as 015? Do you think this is a bug?

  Instead if change common.rc to exported as raw(I am not sure whether
it is done on purpose), how about add a check called:

_required_util

in common.rc?