[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/7] blkdebug: Use errp for read_config()
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v2 1/7] blkdebug: Use errp for read_config() |
Date: |
Fri, 22 Nov 2013 17:10:52 +0100 |
Use an Error variable in the read_config() function.
Signed-off-by: Max Reitz <address@hidden>
---
block/blkdebug.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index 16d2b91..9dfa712 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@@ -271,7 +271,7 @@ static void remove_rule(BlkdebugRule *rule)
g_free(rule);
}
-static int read_config(BDRVBlkdebugState *s, const char *filename)
+static int read_config(BDRVBlkdebugState *s, const char *filename, Error
**errp)
{
FILE *f;
int ret;
@@ -279,11 +279,16 @@ static int read_config(BDRVBlkdebugState *s, const char
*filename)
f = fopen(filename, "r");
if (f == NULL) {
+ error_setg_errno(errp, errno, "Could not read blkdebug config file "
+ "'%s'", filename);
return -errno;
}
ret = qemu_config_parse(f, config_groups, filename);
if (ret < 0) {
+ error_setg(errp, "Could not parse blkdebug config file '%s'",
+ filename);
+ ret = -EINVAL;
goto fail;
}
@@ -370,9 +375,8 @@ static int blkdebug_open(BlockDriverState *bs, QDict
*options, int flags,
/* Read rules from config file */
config = qemu_opt_get(opts, "config");
if (config) {
- ret = read_config(s, config);
- if (ret < 0) {
- error_setg_errno(errp, -ret, "Could not read blkdebug config
file");
+ ret = read_config(s, config, errp);
+ if (ret) {
goto fail;
}
}
--
1.8.4.2
- [Qemu-devel] [PATCH v2 0/7] blkdebug/blkverify: Allow command-line configuration, Max Reitz, 2013/11/22
- [Qemu-devel] [PATCH v2 1/7] blkdebug: Use errp for read_config(),
Max Reitz <=
- [Qemu-devel] [PATCH v2 2/7] blkdebug: Don't require sophisticated filename, Max Reitz, 2013/11/22
- [Qemu-devel] [PATCH v2 3/7] qdict: Add qdict_array_split(), Max Reitz, 2013/11/22
- [Qemu-devel] [PATCH v2 4/7] qemu-option: Add qemu_config_parse_qdict(), Max Reitz, 2013/11/22
- [Qemu-devel] [PATCH v2 5/7] blkdebug: Always call read_config(), Max Reitz, 2013/11/22
- [Qemu-devel] [PATCH v2 6/7] blkdebug: Use command-line in read_config(), Max Reitz, 2013/11/22
- [Qemu-devel] [PATCH v2 7/7] blkverify: Don't require protocol filename, Max Reitz, 2013/11/22