[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 10/11] target-arm: Provide '-cpu host' when r
From: |
Christoffer Dall |
Subject: |
Re: [Qemu-devel] [PATCH v9 10/11] target-arm: Provide '-cpu host' when running KVM |
Date: |
Fri, 22 Nov 2013 11:00:01 -0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Nov 22, 2013 at 06:50:47PM +0000, Peter Maydell wrote:
> On 22 November 2013 18:25, Christoffer Dall <address@hidden> wrote:
> > On Fri, Nov 22, 2013 at 05:17:17PM +0000, Peter Maydell wrote:
> >> +bool kvm_arm_create_scratch_host_vcpu(const uint32_t *cpus_to_try,
> >> + int *fdarray,
> >> + struct kvm_vcpu_init *init);
> >
> > why do we need to export this at all?
>
> For 64 bit KVM support the 32 bit code moves into kvm32.c
> and then we have two users of this function, one in
> kvm32.c and one in kvm64.c. It seemed easiest to just
> make the function public with the proper doc comment
> from the start, rather than starting it private and
> then having a patch which makes it public.
>
Yes, that does make sense.
Thanks.
- [Qemu-devel] [PATCH v9 00/11] target-arm: mach virt and -cpu host support, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 03/11] hw/arm/boot: Allow boards to provide an fdt blob, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 04/11] target-arm: Provide PSCI constants to generic QEMU code, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 05/11] target-arm: Add ARMCPU field for Linux device-tree 'compatible' string, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 01/11] target-arm: Provide mechanism for getting KVM constants even if not CONFIG_KVM, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 11/11] hw/arm/virt: Support -cpu host, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 08/11] linux-headers: Update from mainline, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 06/11] target-arm: Allow secondary KVM CPUs to be booted via PSCI, Peter Maydell, 2013/11/22
- [Qemu-devel] [PATCH v9 07/11] hw/arm: Add 'virt' platform, Peter Maydell, 2013/11/22