qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-1.7 0/5] acpi unit-test: added tests


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH for-1.7 0/5] acpi unit-test: added tests
Date: Sun, 24 Nov 2013 13:33:27 +0200

On Thu, Nov 21, 2013 at 09:33:20PM +0200, Marcel Apfelbaum wrote:
> Added 2 tests:
>  1. Basic check of FACS table (missed on prev submission)
>  2. Compare DSDT and SSDT tables against expected values
> 
> Test 2:
>  - runs only if iasl is installed on the host machine.
>  - the test plan:
>    1. Dumps the ACPI tables as AML on the disk.
>    2. Runs iasl to disassembly the tables into ASL files.
>    3. Compares them with expected offline ASL files.
> 
>  - the test runs for both default machine and q35.
>  - in case the test fails, it can be easily tweaked to
>    show the differences between the ASL files and
>    understand the issue.

That's very useful, thanks.
But why do you want to put this in 1.7?

> Patches:
>  1/5 - test 1
>  2/5 - some infrastructure improvements
>  3/5 - expected asl files for test 2
>  4/5 - creates links for the expected files
>        if the build directory is not current
>  5/5 - test 2
> 
> Marcel Apfelbaum (5):
>   acpi unit-test: load and check facs table
>   acpi unit-test: adjust the test data structure for better handling
>   acpi unit-test: add test files
>   configure: added acpi unit-test files
>   acpi unit-test: compare DSDT and SSDT tables against expected values
> 
>  configure                         |    4 +
>  tests/acpi-test-data/pc/APIC.dsl  |  103 ++
>  tests/acpi-test-data/pc/DSDT.dsl  | 1870 ++++++++++++++++++++++
>  tests/acpi-test-data/pc/FACP.dsl  |   99 ++
>  tests/acpi-test-data/pc/FACS.dsl  |   32 +
>  tests/acpi-test-data/pc/HPET.dsl  |   43 +
>  tests/acpi-test-data/pc/SSDT.dsl  |  634 ++++++++
>  tests/acpi-test-data/q35/APIC.dsl |  103 ++
>  tests/acpi-test-data/q35/DSDT.dsl | 3197 
> +++++++++++++++++++++++++++++++++++++
>  tests/acpi-test-data/q35/FACP.dsl |   99 ++
>  tests/acpi-test-data/q35/FACS.dsl |   32 +
>  tests/acpi-test-data/q35/HPET.dsl |   43 +
>  tests/acpi-test-data/q35/MCFG.dsl |   36 +
>  tests/acpi-test-data/q35/SSDT.dsl |  665 ++++++++
>  tests/acpi-test.c                 |  282 +++-
>  15 files changed, 7210 insertions(+), 32 deletions(-)
>  create mode 100644 tests/acpi-test-data/pc/APIC.dsl
>  create mode 100644 tests/acpi-test-data/pc/DSDT.dsl
>  create mode 100644 tests/acpi-test-data/pc/FACP.dsl
>  create mode 100644 tests/acpi-test-data/pc/FACS.dsl
>  create mode 100644 tests/acpi-test-data/pc/HPET.dsl
>  create mode 100644 tests/acpi-test-data/pc/SSDT.dsl
>  create mode 100644 tests/acpi-test-data/q35/APIC.dsl
>  create mode 100644 tests/acpi-test-data/q35/DSDT.dsl
>  create mode 100644 tests/acpi-test-data/q35/FACP.dsl
>  create mode 100644 tests/acpi-test-data/q35/FACS.dsl
>  create mode 100644 tests/acpi-test-data/q35/HPET.dsl
>  create mode 100644 tests/acpi-test-data/q35/MCFG.dsl
>  create mode 100644 tests/acpi-test-data/q35/SSDT.dsl
> 
> -- 
> 1.8.3.1
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]