[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/7] Drop in_use from BlockDriverState and en
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 0/7] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD |
|
Date: |
Mon, 25 Nov 2013 17:48:29 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Nov 25, 2013 at 10:29:44AM +0100, Kevin Wolf wrote:
> Am 22.11.2013 um 17:58 hat Stefan Hajnoczi geschrieben:
> > On Fri, Nov 22, 2013 at 01:24:47PM +0800, Fam Zheng wrote:
> > Interesting implementation, it looks pretty good. I'll need to review
> > it a second time to track all the operation block/unblocks. It wasn't
> > immediately clear to me whether these patches will restrict something
> > that used to work.
>
> We still have a lot of time for 1.8, so I think we can be radical here:
> If something doesn't have a test case and we don't catch it during the
> normal review, then let's just break it. Someone will find it and then
> we'll get a test case for it, so that it doesn't happen again.
Don't hold it up on my account, but let's still review properly.
Stefan
- [Qemu-devel] [PATCH v4 5/7] block: Parse "backing" option to reference existing BDS, (continued)